Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(source): REFRESH SCHEMA shall keep INCLUDE pk for UPSERT #19384

Merged
merged 2 commits into from
Nov 20, 2024

Conversation

xiangjinwu
Copy link
Contributor

@xiangjinwu xiangjinwu commented Nov 13, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

It is required that an UPSERT source (actually table) to INCLUDE key and use it as primary key. However, when REFRESH SCHEMA, the INCLUDEs are always lost, effectively resulting in UPSERT tables cannot evolve their schemas.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/fix Bug fix label Nov 13, 2024
@xiangjinwu xiangjinwu force-pushed the fix-source-alter-include branch from af3516d to 38852de Compare November 20, 2024 06:46
@xiangjinwu xiangjinwu marked this pull request as ready for review November 20, 2024 06:46
@graphite-app graphite-app bot requested a review from a team November 20, 2024 07:23
Copy link
Contributor

@tabVersion tabVersion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix

Comment on lines +93 to +97
statement ok
ALTER TABLE t REFRESH SCHEMA;

statement ok
drop table t;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to check the new schema meets expectation?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is actually a no-op refresh. We refresh immediately after creation without any schema change. But yes it is always good to test more:

  • schema meets expectation after refresh
  • actual data meets schema after refresh (rather than panic due to mismatch)
  • works for protobuf in addition to avro
  • works for debezium in addition to plain or upsert

@xiangjinwu xiangjinwu added this pull request to the merge queue Nov 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Nov 20, 2024
@xiangjinwu xiangjinwu added this pull request to the merge queue Nov 20, 2024
Merged via the queue into main with commit c1e8f9a Nov 20, 2024
29 of 30 checks passed
@xiangjinwu xiangjinwu deleted the fix-source-alter-include branch November 20, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants