Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix system acl column type to support \l command #19379

Merged
merged 5 commits into from
Nov 14, 2024

Conversation

yezizp2012
Copy link
Member

@yezizp2012 yezizp2012 commented Nov 13, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title, after this PR \l command will be available in risingwave.
FYI, the command will be translated to the following query:

SELECT
  d.datname                                               AS "Name",
  pg_catalog.pg_get_userbyid (d.datdba)                   AS "Owner",
  pg_catalog.pg_encoding_to_char (d.encoding)             AS "Encoding",
  d.datcollate                                            AS "Collate",
  d.datctype                                              AS "Ctype",
  pg_catalog.array_to_string (d.datacl, E'\n') AS "Access privileges"
FROM
  pg_catalog.pg_database AS d
ORDER BY
  1

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

support \l command.

@github-actions github-actions bot added the type/fix Bug fix label Nov 13, 2024
@yezizp2012 yezizp2012 added the user-facing-changes Contains changes that are visible to users label Nov 13, 2024
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an SLT for the query.

SELECT
  d.datname                                               AS "Name",
  pg_catalog.pg_get_userbyid (d.datdba)                   AS "Owner",
  pg_catalog.pg_encoding_to_char (d.encoding)             AS "Encoding",
  d.datcollate                                            AS "Collate",
  d.datctype                                              AS "Ctype",
  pg_catalog.array_to_string (d.datacl, E'\n') AS "Access privileges"
FROM
  pg_catalog.pg_database AS d
ORDER BY
  1

The rest LGTM!

@yezizp2012
Copy link
Member Author

Please add an SLT for the query.

SELECT
  d.datname                                               AS "Name",
  pg_catalog.pg_get_userbyid (d.datdba)                   AS "Owner",
  pg_catalog.pg_encoding_to_char (d.encoding)             AS "Encoding",
  d.datcollate                                            AS "Collate",
  d.datctype                                              AS "Ctype",
  pg_catalog.array_to_string (d.datacl, E'\n') AS "Access privileges"
FROM
  pg_catalog.pg_database AS d
ORDER BY
  1

The rest LGTM!

It's kind of flaky because sqllogictest dynamically creates databases, resulting in unpredictable query results, especially when running in parallel mode. Let me change this query a little bit and add an SLT.

@yezizp2012 yezizp2012 enabled auto-merge November 14, 2024 06:50
@yezizp2012 yezizp2012 added this pull request to the merge queue Nov 14, 2024
Merged via the queue into main with commit c1435dd Nov 14, 2024
28 of 29 checks passed
@yezizp2012 yezizp2012 deleted the fix/array-aclitem branch November 14, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants