feat(memory): Separate total memory configurations for FE and Compactor #19372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto li0k/memory_calculation
hzxa21
approved these changes
Nov 13, 2024
chenzl25
reviewed
Nov 13, 2024
kwannoel
reviewed
Nov 14, 2024
| @@ -159,6 +160,10 @@ pub struct FrontendOpts { | |||
| default_value = "./secrets" | |||
| )] | |||
| pub temp_secret_file_dir: String, | |||
|
|
|||
| /// Total available memory for the frontend node in bytes. Used by both computing and storage. | |||
There was a problem hiding this comment.
Suggested change
| /// Total available memory for the frontend node in bytes. Used by both computing and storage. | |
| /// Total available memory for the frontend node in bytes. Used by frontend. |
There was a problem hiding this comment.
I think this comment is not resolved.
kwannoel
reviewed
Nov 14, 2024
kwannoel
reviewed
Nov 14, 2024
kwannoel
approved these changes
Nov 14, 2024
…nto li0k/memory_calculation
…nto li0k/memory_calculation
|
Should we cherry pick this to 2.1? |
fuyufjh
reviewed
Nov 20, 2024
| @@ -159,6 +160,10 @@ pub struct FrontendOpts { | |||
| default_value = "./secrets" | |||
| )] | |||
| pub temp_secret_file_dir: String, | |||
|
|
|||
| /// Total available memory for the frontend node in bytes. Used by both computing and storage. | |||
There was a problem hiding this comment.
Does storage run in frontend? IIRC, even in local execution mode, the TableScan is pushed to compute nodes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
part of #19245
This PR introduces a separate total memory configuration for FE and Compactor.
In standalone deployment mode, the total_memory of different nodes should be set to achieve memory isolation. (Not included in this PR)
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.