Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: background mview without backfilling should not tracked in barrier runtime info #19355

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

yezizp2012
Copy link
Member

@yezizp2012 yezizp2012 commented Nov 12, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Fixed a bug found in https://buildkite.com/risingwavelabs/main-cron/builds/3843#01931e2c-869a-4314-aa99-849e4747f72c, will open another PR to fix release-2.0.

As title, we need to complete the background materialized view without backfilling during recovery; otherwise, it will be logged in the barrier runtime information and remain unfinished because of the absence of progress reports from actors. Similar logic in normal creation:

if actors.is_empty() {
// The command can be finished immediately.
return Some(TrackingJob::New(TrackingCommand {
info: info.clone(),
replace_table_info: replace_table.cloned(),
}));

Furthermore, it should be noted that Value cannot be recovered and is not permitted in background mode.
/// Check that all leaf nodes must be stream table scan,
/// since that plan node maps to `backfill` executor, which supports recovery.
/// Some other leaf nodes like `StreamValues` do not support recovery, and they
/// cannot use background ddl.
pub(crate) fn plan_can_use_background_ddl(plan: &PlanRef) -> bool {

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor

@wenym1 wenym1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yezizp2012 yezizp2012 enabled auto-merge November 12, 2024 10:32
@yezizp2012 yezizp2012 added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit 98aa20b Nov 12, 2024
38 of 39 checks passed
@yezizp2012 yezizp2012 deleted the fix/finish-no-backfill-in-recovery branch November 12, 2024 11:35
Copy link
Contributor

@kwannoel kwannoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

yezizp2012 added a commit that referenced this pull request Nov 13, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants