-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(streaming): correctly skip problematic table-function input #19353
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
// Whether all table functions has exhausted or has failed for current input row. | ||
let mut fully_consumed = true; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In which case it's considered as "exhausted"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When this condition doesn't meet:
if let Some((i, result)) = state.peek()
&& is_current_input(i)
i.e., the cursor of the state
has moved to the next input.
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
1e85b92
to
be37009
Compare
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
See #19352. Close #19352.
The behavior for table function returning an error in streaming mode will become:
risingwave/src/stream/src/executor/project_set.rs
Lines 205 to 213 in c6d2ba8
As described in #17156, there's currently a limitation that
which behaves kind of strangely. Since it might be uncommon (?) for a table function to fail halfway, I prefer not to document this behavior.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.