Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(meta): reorganize code of global barrier manager (part 2) #19351

Merged
merged 3 commits into from
Nov 12, 2024

Conversation

wenym1
Copy link
Contributor

@wenym1 wenym1 commented Nov 12, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

In #19334, we refactor the code of global barrier manager by simply moving the code to different files, without modifying any of the logics.

In this PR, we further refactor the code of global barrier manager to hide the visibility of some structs or fields to have better encapsulation.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@wenym1 wenym1 enabled auto-merge November 12, 2024 09:48
@wenym1 wenym1 added this pull request to the merge queue Nov 12, 2024
Merged via the queue into main with commit 022c0a4 Nov 12, 2024
33 of 34 checks passed
@wenym1 wenym1 deleted the yiming/global-barrier-worker-reorg-second branch November 12, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants