Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(agg expr): use short_if for append only bool_and and bool_or aggregation #19330

Closed
wants to merge 4 commits into from

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Nov 11, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

This PR is a following of #19275. It:

  1. Utilizes the newly introduced short_if argument of aggregate macro to early stop the aggregation when the result won't change any more.
  2. Fixes a logic bug of aggregate macro when generating the first state, after which we can remove state = "ref" from bool_and.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Copy link
Member Author

stdrc commented Nov 11, 2024

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stdrc and the rest of your teammates on Graphite Graphite

@stdrc stdrc changed the title use shortcurcuit_if for append only bool_and and bool_or perf(agg expr): use shortcurcuit_if for append only bool_and and bool_or aggregation Nov 11, 2024
@stdrc stdrc marked this pull request as ready for review November 11, 2024 08:29
Signed-off-by: Richard Chien <[email protected]>
@stdrc stdrc requested a review from xiangjinwu November 11, 2024 08:31
@stdrc stdrc changed the title perf(agg expr): use shortcurcuit_if for append only bool_and and bool_or aggregation perf(agg expr): use shortcircuit_if for append only bool_and and bool_or aggregation Nov 11, 2024
@stdrc stdrc changed the title perf(agg expr): use shortcircuit_if for append only bool_and and bool_or aggregation perf(agg expr): use short_if for append only bool_and and bool_or aggregation Nov 11, 2024
@stdrc stdrc closed this Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant