Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: cherry-pick #18941 and #19172 (SWAP) to release 2.1 #19287

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

yezizp2012
Copy link
Member

@yezizp2012 yezizp2012 commented Nov 7, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@yezizp2012 yezizp2012 marked this pull request as ready for review November 8, 2024 03:48
@yezizp2012 yezizp2012 requested a review from a team as a code owner November 8, 2024 03:48
@yezizp2012 yezizp2012 requested review from BugenZhao and removed request for a team November 8, 2024 03:48
@xxchan xxchan requested a review from lmatz November 8, 2024 03:50
@yezizp2012 yezizp2012 requested review from shanicky and xxchan November 8, 2024 03:59
@xxchan xxchan changed the title chore: cherry-pick 18941 and 19172 to release 2.1 chore: cherry-pick #18941 and #19172 to release 2.1 Nov 8, 2024
@xxchan xxchan changed the title chore: cherry-pick #18941 and #19172 to release 2.1 chore: cherry-pick #18941 and #19172 (SWAP) to release 2.1 Nov 8, 2024
Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber stamp

@lmatz lmatz added this pull request to the merge queue Nov 8, 2024
Merged via the queue into release-2.1 with commit b207431 Nov 8, 2024
33 of 34 checks passed
@lmatz lmatz deleted the zp/cherry-pick-18941-19172 branch November 8, 2024 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants