Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: some CDC table's code #19255

Merged
merged 12 commits into from
Nov 8, 2024

Conversation

st1page
Copy link
Contributor

@st1page st1page commented Nov 4, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

fix #19284
prepare for #16024
related to #17472

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@st1page st1page changed the title refactor: unify some logic of cdc_table_and_table_with_conn and sink into table refactor: some CDC table's code Nov 5, 2024
@st1page st1page marked this pull request as ready for review November 7, 2024 08:17
@st1page st1page requested review from StrikeW and BugenZhao November 7, 2024 08:17
Copy link
Contributor

@StrikeW StrikeW left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

src/frontend/src/handler/alter_table_column.rs Outdated Show resolved Hide resolved
@st1page st1page enabled auto-merge November 8, 2024 08:09
@st1page st1page added this pull request to the merge queue Nov 8, 2024
Merged via the queue into main with commit c658340 Nov 8, 2024
28 of 29 checks passed
@st1page st1page deleted the sts/refactor_cdc_table_and_table_with_conn branch November 8, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CDC table do not report error with foreign key
2 participants