Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(meta): record delta for new compaction group #19253

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Conversation

zwang28
Copy link
Contributor

@zwang28 zwang28 commented Nov 4, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

There's an optimization in time travel metadata: it will drop any delta log that doesn't add any SSTs. Because previously a new delta log from commit_epoch always belongs to either compaction group 2 or 3, which must exist.

However, during snapshot backfill it's possible that a delta log adds a new compaction group without adding any SSTs, e.g. it includes GroupConstruct but doesn't include any NewL0SubLevel.
This PR fixes the bug by enforcing a new version for time travel for the above new case, similar to how it is handled for delta logs generated by compaction.

This PR also removes useless time_travel_toggle_check, since time travel is always enabled.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@zwang28 zwang28 enabled auto-merge November 4, 2024 10:50
Copy link
Contributor

@Li0k Li0k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick fix

@zwang28 zwang28 added this pull request to the merge queue Nov 4, 2024
Merged via the queue into main with commit 46ad598 Nov 4, 2024
36 of 37 checks passed
@zwang28 zwang28 deleted the wangzheng/fix_meta branch November 4, 2024 17:27
github-merge-queue bot pushed a commit that referenced this pull request Nov 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants