Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix grant and revoke privileges for internal table #19249

Merged
merged 5 commits into from
Nov 7, 2024

Conversation

yezizp2012
Copy link
Member

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor

@kwannoel kwannoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After this PR, we will grant permissions on internal tables of MVs, when we grant permissions on the MV itself.

Can we also extend this to sinks and indexes?

@yezizp2012
Copy link
Member Author

After this PR, we will grant permissions on internal tables of MVs, when we grant permissions on the MV itself.

Can we also extend this to sinks and indexes?

👍 Yes sure, I will extend it in this PR later.

@yezizp2012
Copy link
Member Author

After this PR, we will grant permissions on internal tables of MVs, when we grant permissions on the MV itself.

Can we also extend this to sinks and indexes?

After this PR, The select privilege on an index will be granted or revoked correspondingly with its primary table. This PR also supports grant and revoke select privilege for sink, which means user with select privilege on sink can query its internal tables now. Cc @kwannoel PTAL.

@yezizp2012 yezizp2012 requested a review from kwannoel November 6, 2024 10:21
@graphite-app graphite-app bot requested a review from a team November 6, 2024 10:49
Copy link
Contributor

@kwannoel kwannoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the work.

@yezizp2012 yezizp2012 added this pull request to the merge queue Nov 7, 2024
Merged via the queue into main with commit 218e63e Nov 7, 2024
31 of 32 checks passed
@yezizp2012 yezizp2012 deleted the fix/internal-table-privilege branch November 7, 2024 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants