-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(frontend): support iceberg predicate pushdown #19228
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwannoel
force-pushed
the
kwannoel/iceberg-predicate-pushdown
branch
from
November 7, 2024 03:35
f14d851
to
8572e75
Compare
This comment was marked as resolved.
This comment was marked as resolved.
kwannoel
commented
Nov 8, 2024
kwannoel
commented
Nov 8, 2024
kwannoel
commented
Nov 8, 2024
kwannoel
force-pushed
the
kwannoel/iceberg-predicate-pushdown
branch
from
November 8, 2024 05:49
e4811b5
to
0d2f661
Compare
kwannoel
commented
Nov 11, 2024
chenzl25
reviewed
Nov 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rest LGTM
kwannoel
force-pushed
the
kwannoel/iceberg-predicate-pushdown
branch
2 times, most recently
from
November 14, 2024 03:26
5a0f161
to
dacfabd
Compare
chenzl25
approved these changes
Nov 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
kwannoel
force-pushed
the
kwannoel/iceberg-predicate-pushdown
branch
from
November 14, 2024 08:57
ab1db6f
to
d4cff99
Compare
kwannoel
force-pushed
the
kwannoel/iceberg-predicate-pushdown
branch
from
November 14, 2024 09:00
d4cff99
to
f98b5fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
In this PR, we support predicate pushdown to iceberg sdk.
The sdk will either use
zonemap
, or manually prune data ifzonemap
is not available for iceberg table.We implement iceberg predicate pushdown as a separate pass from the logical predicate pushdown, at the end of batch execution planning. This is because it is logically distinct (pushdown to rw plan nodes vs pushdown to iceberg), we can invoke the predicate pushdown logic just once, and we preserve the
hash
andeq
semantics of theIcebergScan
plan nodes.We also support empty split, in that case we just return no data. It is possible to have empty split, if the predicate prunes out all data from an iceberg table.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.