Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): support iceberg predicate pushdown #19228

Merged
merged 42 commits into from
Nov 14, 2024

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Nov 1, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

In this PR, we support predicate pushdown to iceberg sdk.
The sdk will either use zonemap, or manually prune data if zonemap is not available for iceberg table.

We implement iceberg predicate pushdown as a separate pass from the logical predicate pushdown, at the end of batch execution planning. This is because it is logically distinct (pushdown to rw plan nodes vs pushdown to iceberg), we can invoke the predicate pushdown logic just once, and we preserve the hash and eq semantics of the IcebergScan plan nodes.

We also support empty split, in that case we just return no data. It is possible to have empty split, if the predicate prunes out all data from an iceberg table.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@kwannoel

This comment was marked as resolved.

@kwannoel kwannoel marked this pull request as ready for review November 8, 2024 05:46
@kwannoel kwannoel force-pushed the kwannoel/iceberg-predicate-pushdown branch from e4811b5 to 0d2f661 Compare November 8, 2024 05:49
@graphite-app graphite-app bot requested a review from a team November 8, 2024 08:55
Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rest LGTM

src/connector/src/source/iceberg/mod.rs Outdated Show resolved Hide resolved
src/batch/src/executor/iceberg_scan.rs Outdated Show resolved Hide resolved
src/batch/src/executor/iceberg_scan.rs Outdated Show resolved Hide resolved
@kwannoel kwannoel force-pushed the kwannoel/iceberg-predicate-pushdown branch 2 times, most recently from 5a0f161 to dacfabd Compare November 14, 2024 03:26
@kwannoel kwannoel requested a review from chenzl25 November 14, 2024 03:26
Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kwannoel kwannoel force-pushed the kwannoel/iceberg-predicate-pushdown branch from ab1db6f to d4cff99 Compare November 14, 2024 08:57
@kwannoel kwannoel force-pushed the kwannoel/iceberg-predicate-pushdown branch from d4cff99 to f98b5fe Compare November 14, 2024 09:00
@kwannoel kwannoel enabled auto-merge November 14, 2024 09:00
@kwannoel kwannoel added this pull request to the merge queue Nov 14, 2024
Merged via the queue into main with commit 1a97b4c Nov 14, 2024
32 of 33 checks passed
@kwannoel kwannoel deleted the kwannoel/iceberg-predicate-pushdown branch November 14, 2024 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants