Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: support Kinesis with include timestamp #19211

Merged
merged 2 commits into from
Nov 5, 2024
Merged

fix: support Kinesis with include timestamp #19211

merged 2 commits into from
Nov 5, 2024

Conversation

tabVersion
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

as title
resolve #19210

  • timestamp here indicates approximate_arrival_timestamp, the result is in micro-sec

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@tabVersion tabVersion requested a review from xiangjinwu October 30, 2024 10:04
@github-actions github-actions bot added the type/fix Bug fix label Oct 30, 2024
@tabVersion
Copy link
Contributor Author

test pass with localstack
image

xiangjinwu
xiangjinwu reviewed Nov 1, 2024
View reviewed changes
Copy link
Contributor

@xiangjinwu xiangjinwu left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Possible follow-ups:

  • Resolve the 2 comments below for kafka as well.
  • Confirm that all combinations listed in COMPATIBLE_ADDITIONAL_COLUMNS are truly implemented. No more similar bugs.
  • Include the tests in CI to prevent accidental regression.

src/connector/src/source/kinesis/source/message.rs Outdated Show resolved Hide resolved
src/connector/src/source/kinesis/source/message.rs Outdated Show resolved Hide resolved
@tabVersion tabVersion requested a review from xiangjinwu November 1, 2024 07:02
xiangjinwu
xiangjinwu reviewed Nov 1, 2024
View reviewed changes
src/connector/src/source/kinesis/source/message.rs Outdated Show resolved Hide resolved
src/connector/src/source/kafka/source/message.rs Outdated Show resolved Hide resolved
src/connector/src/parser/mod.rs Outdated Show resolved Hide resolved
integration_tests/kinesis-s3-source/create_source.sql Outdated
Comment on lines 25 to 29
INCLUDE key
INCLUDE partition
INCLUDE offset
INCLUDE timestamp
INCLUDE payload
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No test results need to be updated accordingly?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

integration tests have limited ability on check results. Let's find another way.

@tabVersion tabVersion added this pull request to the merge queue Nov 5, 2024
Merged via the queue into main with commit 0f78e6a Nov 5, 2024
28 of 29 checks passed
@tabVersion tabVersion deleted the tab/kinesis-fix-add branch November 5, 2024 06:49
github-actions bot pushed a commit that referenced this pull request Nov 5, 2024
@tabVersion
fix: support Kinesis with include timestamp (#19211)
236b494 
Co-authored-by: tabversion <[email protected]>
@github-actions github-actions bot mentioned this pull request Nov 5, 2024
Merged
github-actions bot pushed a commit that referenced this pull request Nov 5, 2024
@tabVersion
fix: support Kinesis with include timestamp (#19211)
624855a 
Co-authored-by: tabversion <[email protected]>
@github-actions github-actions bot mentioned this pull request Nov 5, 2024
Merged
github-merge-queue bot pushed a commit that referenced this pull request Nov 5, 2024
@github-actions @tabVersion
fix: support Kinesis with include timestamp (#19211) (#19261)
7ddda3d 
Co-authored-by: Bohan Zhang <[email protected]>
Co-authored-by: tabversion <[email protected]>
github-merge-queue bot pushed a commit that referenced this pull request Nov 5, 2024
@github-actions @tabVersion
fix: support Kinesis with include timestamp (#19211) (#19262)
04e33e7 
Co-authored-by: Bohan Zhang <[email protected]>
Co-authored-by: tabversion <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xiangjinwu xiangjinwu xiangjinwu approved these changes

Assignees
No one assigned
Labels
need-cherry-pick-release-2.0 need-cherry-pick-release-2.1 type/fix Bug fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

bug: Kinesis does not work with include timestamp
2 participants
@tabVersion @xiangjinwu