-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(meta): bump sea-orm to 1.0 #19207
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @BugenZhao and the rest of your teammates on Graphite |
362c3ec
to
c7a7bdc
Compare
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
c7a7bdc
to
9041be4
Compare
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
9713365
to
78f28a7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#19145 🥵
I think we made similar changes. Shall I include your changes in my PR? I think the trait extension changes are more ergonomic. |
I think we can also merge in your PR, then my PR will just contain |
@@ -4489,6 +4489,18 @@ dependencies = [ | |||
"zeroize", | |||
] | |||
|
|||
[[package]] | |||
name = "educe" | |||
version = "0.5.11" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just making sure the duplicated dependency of a different version for educe
here is expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rubber stamp for Cargo.lock
Sorry, I just noticed your work. 🥵 |
#[easy_ext::ext(ColumnDefExt)] | ||
impl ColumnDef { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We may consider disallowing other constructors like blob
and binary
with the help of clippy.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Bump
sea-orm
to1.0
, along with its dependencies.The motivation is #19156, where the necessary fix (SeaQL/sea-orm#2244) is only included since
1.0
.The only worth-noting breaking change is that, there is no longer a backend-agnostic method to specify
longblob
for MySQL,blob
for SQLite, andbytea
for Postgres simultaneously (SeaQL/sea-query#743, a regression to me). As a workaround, add a helper method which dispatches the type based on the backend variant.Although the latest version of
sea-orm
is1.1
, we are not upgrading to it in this PR because it depends on a new major version ofsqlx
, for which we are maintaining our own forks to make it compatible with madsim. We may further bump it in following PRs.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.