Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add label build-image-on-pr to trigger a build #19204

Closed
wants to merge 3 commits into from

Conversation

tabVersion
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

as title, a new label to trigger a workflow to build a new image on the current branch, and labeled as the branch name.

note that the image tag is sanitized: feature/new-thing becomes feature-new-thing

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

ci/workflows/pull-request.yml Outdated Show resolved Hide resolved
@tabVersion tabVersion marked this pull request as ready for review October 30, 2024 08:23
@tabVersion tabVersion requested review from cyliu0 and kwannoel October 30, 2024 08:24
@kwannoel
Copy link
Contributor

You can also add the github label to this PR, to test it works.

@graphite-app graphite-app bot requested a review from a team October 30, 2024 09:10
@BugenZhao BugenZhao requested a review from xxchan November 4, 2024 04:46
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some concerns:

  • It seems that we build the image directly based on the commits in the branch, instead of merging it into the main branch first. I'm afraid there can be confusion when different base commits are used.
  • What if the workflow is triggered multiple times on the same branch, given that we only encode the branch name into the image tag.

@tabVersion tabVersion closed this Nov 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants