Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(frontend): plan nested loop temporal join #19201

Merged
merged 6 commits into from
Nov 1, 2024
Merged

Conversation

yuhao-su
Copy link
Contributor

@yuhao-su yuhao-su commented Oct 30, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • Plan nested loop temporal join for inner and cross join.
  • Add e2e and planner test.

The LHS is the stream side. RHS is the look up table. LHS will be broadcasted and RHS is no-shuffle.

We currently disallow left outer join because LHS will be broadcasted and nested loop temporal join will produce duplicated records from all parallelism when it has a NULL match.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

TODO

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@yuhao-su yuhao-su added the user-facing-changes Contains changes that are visible to users label Oct 30, 2024
@yuhao-su yuhao-su changed the title frontend: plan nested loop temporal join feat(frontend): plan nested loop temporal join Oct 30, 2024
Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks!

@yuhao-su yuhao-su enabled auto-merge November 1, 2024 09:06
@yuhao-su yuhao-su added this pull request to the merge queue Nov 1, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 1, 2024
@yuhao-su yuhao-su enabled auto-merge November 1, 2024 15:08
@yuhao-su yuhao-su added this pull request to the merge queue Nov 1, 2024
Merged via the queue into main with commit d9ee9b4 Nov 1, 2024
30 of 31 checks passed
@yuhao-su yuhao-su deleted the yuhao/plan-nltj branch November 1, 2024 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants