Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename ConnectorSchema/SourceSchema to FormatEncode #19174

Merged
merged 1 commit into from
Oct 30, 2024

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Oct 29, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

"connector schema" is confusing. "format encode" is more easy to understand.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member Author

xxchan commented Oct 29, 2024

@xxchan xxchan marked this pull request as ready for review October 29, 2024 09:42
@xxchan xxchan force-pushed the xxchan/format-encode branch from 707ef1d to 8380625 Compare October 29, 2024 09:57
@xxchan xxchan force-pushed the xxchan/format-encode branch from 8380625 to bbd508f Compare October 29, 2024 13:11
@xxchan xxchan added this pull request to the merge queue Oct 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Oct 29, 2024
@xxchan xxchan added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit b6051d8 Oct 30, 2024
31 of 32 checks passed
@xxchan xxchan deleted the xxchan/format-encode branch October 30, 2024 01:59
xiangjinwu added a commit that referenced this pull request Nov 22, 2024
xiangjinwu added a commit that referenced this pull request Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants