Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(hash agg): don't emit data in HashAgg when stream is paused #19168

Closed
wants to merge 2 commits into from

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Oct 29, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Fix #19117.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

stdrc added 2 commits October 29, 2024 14:48
Signed-off-by: Richard Chien <[email protected]>
Copy link
Member Author

stdrc commented Oct 29, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stdrc and the rest of your teammates on Graphite Graphite

@stdrc stdrc changed the title simple rename fix(hash agg): don't emit data in HashAgg when stream is paused Oct 29, 2024
@github-actions github-actions bot added type/fix Bug fix and removed Invalid PR Title labels Oct 29, 2024
@stdrc stdrc marked this pull request as ready for review October 29, 2024 07:40
Copy link
Contributor

@st1page st1page left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Although the modification is simple, we may still need to test to ensure that it does not result in data loss.

🤔 But it seems hard to test in e2e test.

@fuyufjh
Copy link
Member

fuyufjh commented Oct 30, 2024

I think we need to find out the sources of these watermark events. Because, technically, if there is not incomming events, the watermark won't be updated.

@stdrc
Copy link
Member Author

stdrc commented Oct 30, 2024

I just realized that StreamSort can produce chunks when receiving watermark message. Now I agree that we shouldn't have watermark messages on the stream when the stream is paused.

@stdrc
Copy link
Member Author

stdrc commented Oct 30, 2024

Superseded by #19199.

@stdrc stdrc closed this Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug(sink): panic on "should not receive any data after pause"
3 participants