Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(optimizer): fix lateral subquery with cte #19162

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

chenzl25
Copy link
Contributor

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

  • Resolve bug: lateral subquery with CTE panic #19161
  • CTE query will be wrapped as a Share Relation in the binder and it should be visited when transforming the CorrelatedInputRef.
  • Lateral subquery context depth should be calculated as upper context index + lateral context index.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/fix Bug fix label Oct 29, 2024
@chenzl25 chenzl25 requested review from st1page and xxchan October 29, 2024 03:08
└─BatchHashJoin { type: Inner, predicate: t1.y IS NOT DISTINCT FROM t2.y AND t1.x = t2.x, output: [t1.x, t1.y] }
├─BatchExchange { order: [], dist: HashShard(t1.y) }
│ └─BatchScan { table: t1, columns: [t1.x, t1.y], distribution: SomeShard }
└─BatchGroupTopN { order: [t2.y ASC], limit: 1, offset: 0, group_key: [t2.y] }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔 Could it be the Agg operator? Maybe we should generate LogicalDedup instead of LogicalTopN in ApplyLimitTransposeRule

Copy link
Contributor Author

@chenzl25 chenzl25 Oct 29, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I think we can. Let's open an issue and create another PR to optimize it.
Oh. It only works for limit 1, but not general.

Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chenzl25 chenzl25 enabled auto-merge October 30, 2024 06:38
@chenzl25 chenzl25 added this pull request to the merge queue Oct 30, 2024
Merged via the queue into main with commit be73a02 Oct 30, 2024
32 of 33 checks passed
@chenzl25 chenzl25 deleted the dylan/fix_subquery_with_share branch October 30, 2024 07:45
github-merge-queue bot pushed a commit that referenced this pull request Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: lateral subquery with CTE panic
3 participants