feat: introduce node label #19153
Merged
feat: introduce node label #19153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shanicky
force-pushed
the
peng/node-label
branch
from
101327d to
4d22b04
Compare
shanicky
force-pushed
the
peng/node-label
branch
3 times, most recently
from
5a7017a to
d90fae6
Compare
shanicky
force-pushed
the
peng/node-label
branch
from
d1f87cc to
981e97b
Compare
shanicky
added
the
ci/run-backwards-compat-tests
shanicky
force-pushed
the
peng/node-label
branch
from
981e97b to
0a25900
Compare
9 tasks
yezizp2012
approved these changes
Nov 21, 2024
src/cmd_all/src/standalone.rs
Outdated
| @@ -482,6 +482,7 @@ mod test { | |||
| total_memory_bytes: 34359738368, | |||
| reserved_memory_bytes: None, | |||
| parallelism: 10, | |||
| node_label: "default", | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Signed-off-by: Shanicky Chen <[email protected]>
… for consistency Signed-off-by: Shanicky Chen <[email protected]>
…odule config settings Signed-off-by: Shanicky Chen <[email protected]>
…eferences Signed-off-by: Shanicky Chen <[email protected]>
…alization Signed-off-by: Shanicky Chen <[email protected]>
Signed-off-by: Shanicky Chen <[email protected]>
…st initializations Signed-off-by: Shanicky Chen <[email protected]>
…AddWorkerNodeRequest Signed-off-by: Shanicky Chen <[email protected]>
Signed-off-by: Shanicky Chen <[email protected]>
…info function Signed-off-by: Shanicky Chen <[email protected]>
shanicky
force-pushed
the
peng/node-label
branch
from
0a25900 to
b61ed85
Compare
…tion Signed-off-by: Shanicky Chen <[email protected]>
shanicky
force-pushed
the
peng/node-label
branch
from
a218fb3 to
9fe686f
Compare
xxchan
reviewed
Dec 12, 2024
Comment on lines
223
to
+228
| pub fn parallelism(&self) -> usize { | ||
| self.parallelism as usize | ||
| assert_eq!(self.r#type(), WorkerType::ComputeNode); | ||
| self.property | ||
| .as_ref() | ||
| .expect("property should be exist") | ||
| .parallelism as usize |
There was a problem hiding this comment.
This will panic in some places:
- diagnose in dashboard
show cluster
Can you examine the usages of worker.parallelism()? (Or you may change list_all_nodes() calls to list_cn())
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This PR attempts to add support for node label
Currently, our label is designed as a single string to serve as an option, but the compute node has a default label that is "default"
Regarding Property, since there is currently no good way to define its meaning, this PR first attempts to unify the Property in WorkerNode with the Property in AddWorkerNode.
Checklist
./risedev check(or alias,./risedev c)