Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dashboard): show vnode count for mv/table/internal-table #19133

Merged
merged 2 commits into from
Oct 29, 2024

Conversation

BugenZhao
Copy link
Member

@BugenZhao BugenZhao commented Oct 25, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title. Note that this is not the max_parallelism for streaming jobs.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • All checks passed in ./risedev check (or alias, ./risedev c)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member Author

.map(|s| s.into())
.collect(),
parallelism: distribution.parallelism as i32,
max_parallelism: distribution.vnode_count as i32,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since #18753, vnode_count of singleton fragments is 1, so we don't need a mapping here.

@BugenZhao BugenZhao marked this pull request as ready for review October 29, 2024 06:58
Copy link
Member

@yezizp2012 yezizp2012 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BugenZhao BugenZhao enabled auto-merge October 29, 2024 07:33
@BugenZhao BugenZhao added this pull request to the merge queue Oct 29, 2024
Merged via the queue into main with commit 55d42c8 Oct 29, 2024
34 of 35 checks passed
@BugenZhao BugenZhao deleted the bz/vnode-dashboard branch October 29, 2024 08:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants