-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(madsim,deps): use patched sqlx
managed by the madsim-rs
organization instead of a personal repository
#19130
Conversation
sqlx
managed by the risingwavelabs
org instead of a personal repositorysqlx
managed by the risingwavelabs
organization instead of a personal repository
sqlx
managed by the risingwavelabs
organization instead of a personal repositorysqlx
managed by the risingwavelabs
organization instead of a personal repository
21b8fa5
to
5d46528
Compare
Cargo.lock
Outdated
@@ -9747,7 +9747,7 @@ dependencies = [ | |||
"indoc", | |||
"libc", | |||
"memoffset", | |||
"parking_lot 0.12.1", | |||
"parking_lot 0.11.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the downgrade here expected?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reverted it. Seems really strange. Each time I run cargo update sqlx
, it keeps updating this dependency as well, for some reason.
As the changes are solely to make Otherwise, should we also move other forks, like |
Done. madsim-rs/sqlx#3. |
7bb1fe4
to
11024a5
Compare
sqlx
managed by the risingwavelabs
organization instead of a personal repositorysqlx
managed by the madsim-rs
organization instead of a personal repository
…anization instead of a personal repository (#19130)
|
||
# sqlx version: v0.7.4 | ||
# patch diffs: https://github.com/madsim-rs/sqlx/pull/3 | ||
sqlx = { git = "https://github.com/risingwavelabs/sqlx.git", rev = "ff6d6d2dc0e9e8e47282fd29be006eed7ae3421a" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed it to madsim
, but didn't update it here 🤦 . Regardless they are using the same commit.
I will update this later when bumping sqlx to 0.8.2: #19145
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
We use patched sqlx from the madsim fork, instead of the one in my personal fork of sqlx.
Please review the changes in that fork prior to reviewing this PR.
This accomplishes two things:
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.