refactor(test): unify sr_register usage for avro and protobuf
#19107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangjinwu
commented
Oct 24, 2024
| echo "Error: Arguments cannot be empty" | ||
| exit 1 | ||
| fi | ||
|
|
||
| echo "$schema" | jq '{"schema": tojson}' \ | ||
| jq -Rs "{\"schema\": ., \"schemaType\": \"$encoding\"}" \ |
There was a problem hiding this comment.
-Rs handles non-json input (.proto) while tojson can only handle json (.avsc)
xiangjinwu
force-pushed
the
test-e2e-unify-sr-register
branch
from
c9957a3 to
bea4129
Compare
xiangjinwu
force-pushed
the
test-e2e-unify-sr-register
branch
from
bea4129 to
b843171
Compare
xxchan
reviewed
Oct 25, 2024
e2e_test/sink/kafka/avro.slt
Outdated
Comment on lines
8
to
11
| python3 e2e_test/sink/kafka/register_schema.py 'http://schemaregistry:8082' 'test-rw-sink-upsert-avro-value' src/connector/src/test_data/all-types.avsc | ||
| jq '.fields = (.fields | map(select(.name | test("unsupported|mon_day_sec_field") | not)))' src/connector/src/test_data/all-types.avsc | sr_register 'test-rw-sink-upsert-avro-value' AVRO | ||
|
|
||
| system ok | ||
| python3 e2e_test/sink/kafka/register_schema.py 'http://schemaregistry:8082' 'test-rw-sink-upsert-avro-key' src/connector/src/test_data/all-types.avsc 'string_field,int32_field' | ||
| jq '.fields = (.fields | map(select(.name | test("string_field|int32_field"))))' src/connector/src/test_data/all-types.avsc | sr_register 'test-rw-sink-upsert-avro-key' AVRO |
There was a problem hiding this comment.
better to add comments for what the jq is doing here
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.