Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(pg-cdc): handle citext data type and other string compatible data types #19103

Merged
merged 2 commits into from
Oct 25, 2024

Conversation

StrikeW
Copy link
Contributor

@StrikeW StrikeW commented Oct 24, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Support mapping citext data type and other string compatible data types

ref: link

close: #18844

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor

@xiangjinwu xiangjinwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We shall warn users, at least in the doc, that these data types would lose their original semantic after being ingested as varchar. For example,

'foo'::char(5) = 'foo '::char(5)
'foo'::varchar <> 'foo '::varchar

@StrikeW StrikeW added this pull request to the merge queue Oct 25, 2024
Merged via the queue into main with commit ef22d0e Oct 25, 2024
29 of 30 checks passed
@StrikeW StrikeW deleted the siyuan/fix-pg-citext branch October 25, 2024 08:58
github-merge-queue bot pushed a commit that referenced this pull request Oct 25, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Risingwave doesn't store postgres citext values
2 participants