feat(compaction): per table vnode on compactor side #19059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nto li0k/compaction_table_vnode
|
| GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
|---|---|---|---|---|---|
| 9425213 | Triggered | Generic Password | 8982c65 | risedev.yml | View secret |
| 9425213 | Triggered | Generic Password | 8982c65 | e2e_test/source_inline/tvf/postgres_query.slt | View secret |
| 9425213 | Triggered | Generic Password | 8982c65 | e2e_test/source_inline/tvf/postgres_query.slt | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
…nto li0k/compaction_table_vnode
BugenZhao
reviewed
Oct 23, 2024
…nto li0k/compaction_table_vnode
Sure, I'm adding a UT for different table vnode counts, and since this logic only affects switch sst at the moment, the UT is only tested for this behaviour. |
…nto li0k/compaction_table_vnode
hzxa21
reviewed
Oct 28, 2024
| /// `CompactionCatalogManager` is a manager to manage all `Table` which used in compaction | ||
| pub struct CompactionCatalogManager { | ||
| // `table_id_to_catalog` is a map to store all `Table` which used in compaction | ||
| table_id_to_catalog: RwLock<HashMap<StateTableId, Arc<Table>>>, |
There was a problem hiding this comment.
IIUC, there is no need to use Arc for Arc<Table>.
…nto li0k/compaction_table_vnode
hzxa21
approved these changes
Oct 31, 2024
| /// `CompactionCatalogManager` is a manager to manage all `Table` which used in compaction | ||
| pub struct CompactionCatalogManager { | ||
| // `table_id_to_catalog` is a map to store all `Table` which used in compaction | ||
| table_id_to_catalog: RwLock<HashMap<StateTableId, Arc<Table>>>, |
…nto li0k/compaction_table_vnode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
related to #18888
This PR refactors the
FilterKeyExtractorand leverages the existingCatalogcapability to provide the ability to extract key and get vnode count.FilterKeyExtractortoCompactionCatalogManagerCompactionCatalogAgentto serve a compaction once, making it easier to test.vnodebytable_id(vnode is calculated by Table catalog).Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.