Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(batch): support extended declare query cursor #19043

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

KeXiangWang
Copy link
Contributor

@KeXiangWang KeXiangWang commented Oct 22, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As titled, resolve #17661

An example:

DECLARE c1 CURSOR FOR  SELECT id, trading_date, volume FROM public.tb_cjg_1 WHERE ((id = CAST($1 AS INT)));

Note: DECLARE SUBSCRIPTION CURSOR with parameter is not supported in this PR.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@fuyufjh
Copy link
Member

fuyufjh commented Oct 23, 2024

Shall we add a test case in e2e_test/extended_mode?

Copy link

gitguardian bot commented Oct 23, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9425213 Triggered Generic Password 5c2aed3 risedev.yml View secret
9425213 Triggered Generic Password 5c2aed3 e2e_test/source_inline/tvf/postgres_query.slt View secret
9425213 Triggered Generic Password 5c2aed3 e2e_test/source_inline/tvf/postgres_query.slt View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@KeXiangWang
Copy link
Contributor Author

Shall we add a test case in e2e_test/extended_mode?

Currently, we cannot send a extended query via psql or python (psycopg2), so I added some tests in integration test instead.

@KeXiangWang
Copy link
Contributor Author

Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuyufjh
Copy link
Member

fuyufjh commented Nov 18, 2024

Ping. Any update?

@KeXiangWang KeXiangWang added this pull request to the merge queue Nov 18, 2024
@KeXiangWang
Copy link
Contributor Author

KeXiangWang commented Nov 18, 2024

Ping. Any update?

Forget to merge.

Merged via the queue into main with commit 7ba6650 Nov 18, 2024
28 of 30 checks passed
@KeXiangWang KeXiangWang deleted the wkx/support-extended-declare-query-cursor branch November 18, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SQL parameter error when querying risingwave via Postgres FDW
4 participants