Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose connection options for sql meta store #19040

Merged
merged 2 commits into from
Oct 24, 2024

Conversation

yezizp2012
Copy link
Member

@yezizp2012 yezizp2012 commented Oct 21, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

It would benefit shared clusters in the rw cloud. To utilize a single RDS for a free-tier/standard cluster without impacting its performance, we can manually configure it.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@yezizp2012 yezizp2012 marked this pull request as ready for review October 24, 2024 05:20
@fuyufjh fuyufjh changed the title chore: expose connection options for sql meta store feat: expose connection options for sql meta store Oct 24, 2024
Copy link
Member

@fuyufjh fuyufjh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please add some background/context in the PR desciption.

Copy link
Contributor

@arkbriar arkbriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

cc. @Gogomoe for awareness.

@arkbriar
Copy link
Contributor

Shall we cherry-pick the PR to 2.1 release?

@yezizp2012
Copy link
Member Author

yezizp2012 commented Oct 24, 2024

Shall we cherry-pick the PR to 2.1 release?

Yes sure sir.

This comment was marked as resolved.

@tabVersion
Copy link
Contributor

Shall we cherry-pick the PR to 2.1 release?

Yes sure sir.

Passion!

Copy link
Contributor

@shanicky shanicky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LPTM!

@yezizp2012 yezizp2012 added this pull request to the merge queue Oct 24, 2024
Merged via the queue into main with commit 65ed113 Oct 24, 2024
30 of 31 checks passed
@yezizp2012 yezizp2012 deleted the chore/expose-sql-backend-conn-opts branch October 24, 2024 10:04
github-merge-queue bot pushed a commit that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants