Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(mysql-cdc): support mysql source capture multiple databases #19038

Merged
merged 11 commits into from
Oct 25, 2024

Conversation

StrikeW
Copy link
Contributor

@StrikeW StrikeW commented Oct 21, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As title.
User can ingest table in different database by specifying multiple database names in the database.name field.

create source mysql_source with (
 connector = 'mysql-cdc',
 ...
 database.name = 'mydb,kdb'
);

create table t1 (*) from mysql_source table "kdb.t1";

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

  • support capturing multiple databases for mysql cdc source

@StrikeW StrikeW changed the title feat(mysql-cdc): mysql source multi database feat(mysql-cdc): support mysql source capture multiple databases Oct 21, 2024
Copy link

gitguardian bot commented Oct 23, 2024

⚠️ GitGuardian has uncovered 3 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9425213 Triggered Generic Password 0aa5af1 risedev.yml View secret
9425213 Triggered Generic Password 0aa5af1 e2e_test/source_inline/tvf/postgres_query.slt View secret
9425213 Triggered Generic Password 0aa5af1 e2e_test/source_inline/tvf/postgres_query.slt View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@graphite-app graphite-app bot requested a review from a team October 23, 2024 15:06
@StrikeW StrikeW requested review from hzxa21 and KeXiangWang October 24, 2024 03:52
Copy link
Contributor

@KeXiangWang KeXiangWang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

var dbName = userProps.get(DbzConnectorConfig.DB_NAME);
var jdbcUrl = ValidatorUtils.getJdbcUrl(SourceTypeE.MYSQL, dbHost, dbPort, dbName);

var jdbcUrl = String.format("jdbc:mysql://%s:%s", dbHost, dbPort);
Copy link
Contributor

@KeXiangWang KeXiangWang Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we then delete the MYSQL branch in ValidatorUtils.getJdbcUrl?

var ret = res.getInt(1);
if (ret == 0) {
throw ValidatorUtils.invalidArgument(
String.format("MySQL database '%s' doesn't exist", dbName));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

String.format("MySQL database '%s' doesn't exist", dbName.trim()));

@StrikeW StrikeW added this pull request to the merge queue Oct 25, 2024
@StrikeW StrikeW removed this pull request from the merge queue due to a manual request Oct 25, 2024
@StrikeW StrikeW enabled auto-merge October 25, 2024 04:33
@StrikeW StrikeW added this pull request to the merge queue Oct 25, 2024
Merged via the queue into main with commit a89abcf Oct 25, 2024
28 of 30 checks passed
@StrikeW StrikeW deleted the siyuan/mysql-multi-db branch October 25, 2024 06:02
xxchan pushed a commit that referenced this pull request Nov 8, 2024
ly9chee pushed a commit to ly9chee/risingwave that referenced this pull request Nov 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants