-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(mysql-cdc): support mysql source capture multiple databases #19038
Conversation
|
GitGuardian id | GitGuardian status | Secret | Commit | Filename | |
---|---|---|---|---|---|
9425213 | Triggered | Generic Password | 0aa5af1 | risedev.yml | View secret |
9425213 | Triggered | Generic Password | 0aa5af1 | e2e_test/source_inline/tvf/postgres_query.slt | View secret |
9425213 | Triggered | Generic Password | 0aa5af1 | e2e_test/source_inline/tvf/postgres_query.slt | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secrets safely. Learn here the best practices.
- Revoke and rotate these secrets.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
var dbName = userProps.get(DbzConnectorConfig.DB_NAME); | ||
var jdbcUrl = ValidatorUtils.getJdbcUrl(SourceTypeE.MYSQL, dbHost, dbPort, dbName); | ||
|
||
var jdbcUrl = String.format("jdbc:mysql://%s:%s", dbHost, dbPort); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we then delete the MYSQL
branch in ValidatorUtils.getJdbcUrl
?
var ret = res.getInt(1); | ||
if (ret == 0) { | ||
throw ValidatorUtils.invalidArgument( | ||
String.format("MySQL database '%s' doesn't exist", dbName)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
String.format("MySQL database '%s' doesn't exist", dbName.trim()));
) (#19125) Co-authored-by: StrikeW <[email protected]>
) Signed-off-by: xxchan <[email protected]>
…atabases risingwavelabs#19038 to 2.0 (risingwavelabs#19317) Signed-off-by: xxchan <[email protected]> Co-authored-by: StrikeW <[email protected]>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
As title.
User can ingest table in different database by specifying multiple database names in the
database.name
field.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note