Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqlparser): Display changelog with quoted identifiers #19029

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

xiangjinwu
Copy link
Contributor

@xiangjinwu xiangjinwu commented Oct 21, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Minor bug since #17132 (v2.0.1)

  • When processing the value in binder, use Identifier::real_value;
  • When Display (unparse), use Identifier as Display;
user input real_value Display explanation
abc abc abc trivial
"as" as "as" Keywords must be quoted.
aBc abc aBc or abc PostgreSQL folds unquoted identifiers to lowercase.
"aBc" aBc "aBc" To preserve cases, use double quotes.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xiangjinwu xiangjinwu added this pull request to the merge queue Oct 21, 2024
Merged via the queue into main with commit 43544ac Oct 21, 2024
32 of 33 checks passed
@xiangjinwu xiangjinwu deleted the fix-sqlparser-changelog-display branch October 21, 2024 07:33
@xxhZs xxhZs added need-cherry-pick-release-1.10 Open a cherry-pick PR to branch release-1.10 after the current PR is merged need-cherry-pick-release-2.0 labels Oct 24, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 24, 2024
…-2.1 (#19098)

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Co-authored-by: yihong <zouzou0208@gmail.com>
Co-authored-by: xiangjinwu <17769960+xiangjinwu@users.noreply.github.com>
github-merge-queue bot pushed a commit that referenced this pull request Oct 24, 2024
…-2.0 (#19096)

Signed-off-by: yihong0618 <zouzou0208@gmail.com>
Co-authored-by: yihong <zouzou0208@gmail.com>
Co-authored-by: xiangjinwu <17769960+xiangjinwu@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-cherry-pick-release-1.10 Open a cherry-pick PR to branch release-1.10 after the current PR is merged need-cherry-pick-release-2.0 need-cherry-pick-release-2.1 type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants