Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqlparser): suspend keyword WITH as an identifier #19022

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

chagelo
Copy link
Contributor

@chagelo chagelo commented Oct 19, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

close #17458

related to #5400, #5125

  • suspend keyword WITH as an identifier
  • fix caret wrong position when there is a syntax error

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@chagelo chagelo force-pushed the fix-alias-using-with-error branch 6 times, most recently from 76bf1b4 to 6bd7659 Compare October 21, 2024 08:26
@chagelo chagelo force-pushed the fix-alias-using-with-error branch from 6bd7659 to 6bde5e2 Compare November 3, 2024 02:04
Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the late review. The changes for the error msg LGTM. I can merge that part first if you want.

@chagelo chagelo force-pushed the fix-alias-using-with-error branch from 4fe75e7 to 998f714 Compare November 28, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sqlparser: confusing error message (keyword used as identifier)
2 participants