Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: refactor pg tvf tests into inline tests #19004

Merged
merged 7 commits into from
Oct 22, 2024
Merged

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Oct 18, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

As per title.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link

gitguardian bot commented Oct 18, 2024

⚠️ GitGuardian has uncovered 15 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id GitGuardian status Secret Commit Filename
9425213 Triggered Generic Password 66ab853 e2e_test/source_inline/tvf/postgres_query.slt View secret
9425213 Triggered Generic Password e34d1c5 e2e_test/source_inline/tvf/postgres_query.slt View secret
9425213 Triggered Generic Password 66ab853 e2e_test/source_inline/tvf/postgres_query.slt View secret
9425213 Triggered Generic Password 66ab853 e2e_test/source_inline/tvf/postgres_query.slt View secret
9425213 Triggered Generic Password 66ab853 e2e_test/source_inline/tvf/postgres_query.slt View secret
9425213 Triggered Generic Password e34d1c5 e2e_test/source_inline/tvf/postgres_query.slt View secret
9425213 Triggered Generic Password 66ab853 e2e_test/source_inline/tvf/postgres_query.slt View secret
9425213 Triggered Generic Password 22fd525 e2e_test/source_inline/tvf/postgres_query.slt View secret
9425213 Triggered Generic Password 22fd525 e2e_test/source_inline/tvf/postgres_query.slt View secret
9425213 Triggered Generic Password e34d1c5 e2e_test/source_inline/tvf/postgres_query.slt View secret
9425213 Triggered Generic Password 22fd525 e2e_test/source_inline/tvf/postgres_query.slt View secret
9425213 Triggered Generic Password e34d1c5 e2e_test/source_inline/tvf/postgres_query.slt View secret
9425213 Triggered Generic Password 66ab853 e2e_test/source_inline/tvf/postgres_query.slt View secret
9425213 Triggered Generic Password e34d1c5 e2e_test/source_inline/tvf/postgres_query.slt View secret
9425213 Triggered Generic Password c60a740 risedev.yml View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@github-actions github-actions bot added the component/test Test related issue. label Oct 18, 2024
@kwannoel kwannoel force-pushed the kwannoel/inline-pg-tvf branch 3 times, most recently from e336b56 to 80326df Compare October 18, 2024 09:15
@graphite-app graphite-app bot requested a review from a team October 18, 2024 09:47
@kwannoel kwannoel marked this pull request as draft October 18, 2024 10:00
@kwannoel
Copy link
Contributor Author

Need to use common risedev env vars, so it can be ran locally too.

@kwannoel kwannoel marked this pull request as ready for review October 18, 2024 10:32
risedev.yml Outdated Show resolved Hide resolved
@kwannoel kwannoel force-pushed the kwannoel/inline-pg-tvf branch from 3f0e2d6 to aa32fcf Compare October 21, 2024 02:38
@kwannoel kwannoel force-pushed the kwannoel/inline-pg-tvf branch from aa32fcf to 22fd525 Compare October 21, 2024 06:03
@kwannoel kwannoel requested a review from xxchan October 22, 2024 01:55
Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM. Thanks!

BTW feel free to share if you have any feedbacks or thoughts about the testing pattern.

@kwannoel kwannoel enabled auto-merge October 22, 2024 04:37
@kwannoel kwannoel added this pull request to the merge queue Oct 22, 2024
Merged via the queue into main with commit 9b42fb0 Oct 22, 2024
29 of 30 checks passed
@kwannoel kwannoel deleted the kwannoel/inline-pg-tvf branch October 22, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test Test related issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants