-
Notifications
You must be signed in to change notification settings - Fork 591
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(frontend): allow INCLUDE payload
without other columns
#19003
Conversation
@@ -667,7 +661,7 @@ pub fn handle_addition_columns( | |||
); | |||
} | |||
let col = build_additional_column_desc( | |||
latest_col_id.next(), | |||
ColumnId::placeholder(), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The latest_col_id.next()
logic was wrong #13707 because it always returns the same value in this while
loop given latest_col_id
is not mut
. The actual column id is assigned in the caller after calling handle_addition_columns
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
random thoughts: Maybe we should rename bind_all_columns
, or move handle_addition_columns
into it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…#19006) Co-authored-by: xiangjinwu <[email protected]>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Since #18437 we have supported
INCLUDE payload
to ingest the whole json payload as a singlejsonb
column:However, when there is no need to extract
foo
orbar
, an empty column list would result in the following error:This PR enables such usage by moving the empty column list check after handling
INCLUDE
additional columns.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.