refactor: distinguish between placeholder and compat for vnode count #18976
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @BugenZhao and the rest of your teammates on |
|
The CI is expected to fail now because the revealed issue will be resolved in an unmerged PR (#18944). |
BugenZhao
force-pushed
the
bz/var-vnode-more-check
branch
from
be6983e to
7221dd5
Compare
BugenZhao
changed the base branch from
main
to
bz/create-mv-only-notify-complete-catalogs
4 tasks
BugenZhao
force-pushed
the
bz/create-mv-only-notify-complete-catalogs
branch
from
0c7b344 to
b365566
Compare
BugenZhao
force-pushed
the
bz/var-vnode-more-check
branch
from
7221dd5 to
6c15e17
Compare
BugenZhao
changed the base branch from
bz/create-mv-only-notify-complete-catalogs
to
main
BugenZhao
force-pushed
the
bz/var-vnode-more-check
branch
from
6c15e17 to
7a50b0b
Compare
BugenZhao
changed the base branch from
main
to
bz/create-mv-only-notify-complete-catalogs
BugenZhao
commented
Oct 18, 2024
BugenZhao
force-pushed
the
bz/var-vnode-more-check
branch
from
7a50b0b to
e023ece
Compare
BugenZhao
force-pushed
the
bz/var-vnode-more-check
branch
2 times, most recently
from
265a7ac to
ad6d5f5
Compare
Base automatically changed from
bz/create-mv-only-notify-complete-catalogs
to
main
October 21, 2024 08:29
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
Signed-off-by: Bugen Zhao <[email protected]>
BugenZhao
force-pushed
the
bz/var-vnode-more-check
branch
from
ad6d5f5 to
c6ca978
Compare
Signed-off-by: Bugen Zhao <[email protected]>
4 tasks
github-actions bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
…18976) Signed-off-by: Bugen Zhao <[email protected]>
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 22, 2024
…18976) (#19047) Signed-off-by: Bugen Zhao <[email protected]> Co-authored-by: Bugen Zhao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Distinguish between the placeholder value and backward-compatible value for
vnode_countfield in table catalog.During the process of creating a streaming job, incomplete catalogs will be temporarily synchronized to the frontend nodes, where
vnode_countremains placeholders. This PR prevents access tovnode_countin this scenario, avoiding hitting the backward-compatibility path that could silently and inadvertently return an incorrect value.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.