-
Notifications
You must be signed in to change notification settings - Fork 598
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: parallelize e2e_test/source_inline #18971
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
99f19d7
to
223b017
Compare
Signed-off-by: xxchan <[email protected]>
a074a46
to
bf2ba5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Topic name conflict with protobuf/basic.slt
sleep 1s | ||
|
||
statement ok | ||
flush; | ||
|
||
query B | ||
select _rw_kafka_timestamp < now() from s1 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems to be flaky test
Signed-off-by: xxchan <[email protected]>
bf2ba5b
to
4e2fff6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]> Co-authored-by: xxchan <[email protected]>
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
The inline tests are generally self-contained: each test create its own test data (like Kafka topics) in the
slt
, so it should be safe to parallelize them.Previous time of this step is 5min, Now it takes 3min.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.