Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: parallelize e2e_test/source_inline #18971

Merged
merged 6 commits into from
Oct 18, 2024
Merged

ci: parallelize e2e_test/source_inline #18971

merged 6 commits into from
Oct 18, 2024

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Oct 17, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

The inline tests are generally self-contained: each test create its own test data (like Kafka topics) in the slt, so it should be safe to parallelize them.

Previous time of this step is 5min, Now it takes 3min.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xxchan

This comment was marked as resolved.

@xxchan xxchan closed this Oct 17, 2024
@xxchan xxchan reopened this Oct 18, 2024
@xxchan xxchan force-pushed the xxchan/managing-mole branch from 99f19d7 to 223b017 Compare October 18, 2024 00:48
@xxchan xxchan force-pushed the xxchan/managing-mole branch 2 times, most recently from a074a46 to bf2ba5b Compare October 18, 2024 02:55
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Topic name conflict with protobuf/basic.slt

Comment on lines 74 to 80
sleep 1s

statement ok
flush;

query B
select _rw_kafka_timestamp < now() from s1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be flaky test

Signed-off-by: xxchan <[email protected]>
@xxchan xxchan force-pushed the xxchan/managing-mole branch from bf2ba5b to 4e2fff6 Compare October 18, 2024 06:56
@xxchan xxchan requested review from stdrc and BugenZhao October 18, 2024 07:23
@graphite-app graphite-app bot requested a review from a team October 18, 2024 07:30
Copy link
Member

@stdrc stdrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xxchan xxchan added this pull request to the merge queue Oct 18, 2024
@xxchan xxchan removed this pull request from the merge queue due to a manual request Oct 18, 2024
@xxchan xxchan added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit 60e124d Oct 18, 2024
29 of 30 checks passed
@xxchan xxchan deleted the xxchan/managing-mole branch October 18, 2024 12:14
github-actions bot pushed a commit that referenced this pull request Oct 18, 2024
github-merge-queue bot pushed a commit that referenced this pull request Oct 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants