Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(test): move some tests from source_legacy to source_inline #18894

Merged
merged 1 commit into from
Oct 15, 2024
Merged

refactor(test): move some tests from source_legacy to source_inline #18894

merged 1 commit into from
Oct 15, 2024

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Oct 14, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xxchan xxchan marked this pull request as ready for review October 14, 2024 08:44
@xxchan xxchan mentioned this pull request Oct 14, 2024
Merged
9 tasks
@xxchan Graphite App
Copy link
Member Author

xxchan commented Oct 14, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @xxchan and the rest of your teammates on Graphite Graphite

@xxchan xxchan mentioned this pull request Oct 14, 2024
Merged
9 tasks
@xxchan xxchan force-pushed the 10-14-refactor_test_move_some_tests_from_source_legacy_to_source_inline branch from d2cfe68 to 0a5af9d Compare October 14, 2024 08:46
xxchan
xxchan commented Oct 14, 2024
View reviewed changes
e2e_test/source_legacy/basic/nexmark/nexmark_endless_part1.slt.part
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dead test file

xxchan
xxchan commented Oct 14, 2024
View reviewed changes
e2e_test/source_legacy/basic/scripts/test_data/weiling.1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dead test file

@xxchan xxchan force-pushed the 10-14-refactor_test_move_some_tests_from_source_legacy_to_source_inline branch from 0a5af9d to dcc042c Compare October 14, 2024 08:50
@xxchan xxchan force-pushed the 10-14-refactor_test_mv branch from 1f4ec34 to adbe294 Compare October 14, 2024 09:01
@xxchan xxchan force-pushed the 10-14-refactor_test_move_some_tests_from_source_legacy_to_source_inline branch from dcc042c to d61ec3e Compare October 14, 2024 09:01
xxchan
xxchan commented Oct 14, 2024
View reviewed changes
e2e_test/source_legacy/basic/scripts/test_data/json_timestamptz_handling_mode.1
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to inline style

@xxchan xxchan requested a review from BugenZhao October 14, 2024 09:06
@xxchan xxchan force-pushed the 10-14-refactor_test_mv branch from adbe294 to a251518 Compare October 14, 2024 09:14
@xxchan xxchan force-pushed the 10-14-refactor_test_move_some_tests_from_source_legacy_to_source_inline branch from d61ec3e to 9bbf2f2 Compare October 14, 2024 09:14
@xxchan xxchan force-pushed the 10-14-refactor_test_mv branch from a251518 to 7554b24 Compare October 14, 2024 09:29
@xxchan xxchan force-pushed the 10-14-refactor_test_move_some_tests_from_source_legacy_to_source_inline branch from 9bbf2f2 to ec9d8ec Compare October 14, 2024 09:29
@xxchan xxchan requested review from stdrc and tabVersion October 14, 2024 09:30
@xxchan xxchan force-pushed the 10-14-refactor_test_mv branch from 7554b24 to 3cf7f48 Compare October 14, 2024 10:46
@xxchan xxchan force-pushed the 10-14-refactor_test_move_some_tests_from_source_legacy_to_source_inline branch from ec9d8ec to 78e2b63 Compare October 14, 2024 10:47
@xxchan xxchan force-pushed the 10-14-refactor_test_mv branch from 3cf7f48 to 00d137b Compare October 14, 2024 11:11
@xxchan xxchan force-pushed the 10-14-refactor_test_move_some_tests_from_source_legacy_to_source_inline branch from 78e2b63 to f4ac37e Compare October 14, 2024 11:11
@xxchan xxchan force-pushed the 10-14-refactor_test_mv branch from 00d137b to 991cd95 Compare October 14, 2024 11:59
@xxchan xxchan force-pushed the 10-14-refactor_test_move_some_tests_from_source_legacy_to_source_inline branch from f4ac37e to 19eedb3 Compare October 14, 2024 11:59
@xxchan xxchan force-pushed the 10-14-refactor_test_mv branch from 991cd95 to 605eb34 Compare October 14, 2024 12:26
@xxchan xxchan force-pushed the 10-14-refactor_test_move_some_tests_from_source_legacy_to_source_inline branch 2 times, most recently from 7757d16 to 660fa6c Compare October 14, 2024 12:54
@xxchan xxchan mentioned this pull request Oct 14, 2024
Merged
12 tasks
Base automatically changed from 10-14-refactor_test_mv to main October 14, 2024 13:45
@xxchan xxchan force-pushed the 10-14-refactor_test_move_some_tests_from_source_legacy_to_source_inline branch 2 times, most recently from eaebb9c to 1104609 Compare October 14, 2024 14:18
stdrc
stdrc approved these changes Oct 15, 2024
View reviewed changes
Copy link
Member

@stdrc stdrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@xxchan xxchan force-pushed the 10-14-refactor_test_move_some_tests_from_source_legacy_to_source_inline branch from 1104609 to ff338ad Compare October 15, 2024 07:54
@xxchan xxchan mentioned this pull request Oct 15, 2024
Merged
9 tasks
@xxchan xxchan force-pushed the 10-14-refactor_test_move_some_tests_from_source_legacy_to_source_inline branch from ff338ad to 342f9fa Compare October 15, 2024 08:52
@xxchan xxchan enabled auto-merge October 15, 2024 08:52
@xxchan xxchan force-pushed the 10-14-refactor_test_move_some_tests_from_source_legacy_to_source_inline branch from 342f9fa to 56d915d Compare October 15, 2024 10:54
@xxchan xxchan force-pushed the 10-14-refactor_test_move_some_tests_from_source_legacy_to_source_inline branch from 56d915d to 194940b Compare October 15, 2024 12:09
@xxchan xxchan added this pull request to the merge queue Oct 15, 2024
@graphite-app graphite-app bot requested a review from a team October 15, 2024 12:43
Merged via the queue into main with commit efbbc7d Oct 15, 2024
30 of 31 checks passed
@xxchan xxchan deleted the 10-14-refactor_test_move_some_tests_from_source_legacy_to_source_inline branch October 15, 2024 13:17
This was referenced Oct 16, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stdrc stdrc stdrc approved these changes

@BugenZhao BugenZhao Awaiting requested review from BugenZhao

@tabVersion tabVersion Awaiting requested review from tabVersion

Assignees
No one assigned
Labels
type/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@xxchan @stdrc