Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: impl ack and migrate to durable consumer for Nats #18873

Merged
merged 6 commits into from
Oct 16, 2024

Merge branch 'main' into tab/nats-offset

02f28b8
Select commit
Loading
Failed to load commit list.
Merged

refactor: impl ack and migrate to durable consumer for Nats #18873

Merge branch 'main' into tab/nats-offset
02f28b8
Select commit
Loading
Failed to load commit list.
GitGuardian / GitGuardian Security Checks failed Oct 15, 2024 in 1s

3 secrets uncovered!

3 secrets were uncovered from the scan of 6 commits in your pull request. ❌

Please have a look to GitGuardian findings and remediate in order to secure your code.

Details

🔎 Detected hardcoded secrets in your pull request

  • Pull request #18873: tab/nats-offset 👉 main
GitGuardian id GitGuardian status Secret Commit Filename
9425213 Triggered Generic Password a6ffcd6 e2e_test/source/tvf/postgres_query.slt View secret
9425213 Triggered Generic Password a6ffcd6 e2e_test/source/tvf/postgres_query.slt View secret
9425213 Triggered Generic Password 02f28b8 ci/scripts/e2e-source-test.sh View secret

🛠 Guidelines to remediate hardcoded secrets

  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.