Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(udf): upgrade arrow-udf to 0.5 which fixes rust udf compilation #18862

Merged
merged 3 commits into from
Oct 11, 2024

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Oct 11, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Fix #18797.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member Author

stdrc commented Oct 11, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @stdrc and the rest of your teammates on Graphite Graphite

@stdrc stdrc changed the title upgrade arrow-udf to 0.5 fix(udf): upgrade arrow-udf to 0.5 which fixes rust udf compilation Oct 11, 2024
@github-actions github-actions bot added type/fix Bug fix and removed Invalid PR Title labels Oct 11, 2024
@stdrc stdrc marked this pull request as ready for review October 11, 2024 06:22
@stdrc stdrc requested review from xxchan and BugenZhao October 11, 2024 06:26
@graphite-app graphite-app bot requested a review from a team October 11, 2024 06:49
Copy link
Member

@xxchan xxchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So why CI didn't fail? 👀

@stdrc
Copy link
Member Author

stdrc commented Oct 11, 2024

So why CI didn't fail? 👀

Oh, I got it. That's because it'll only fail to compile when there's array type in arguments. Let me add a test for this.

@stdrc stdrc force-pushed the rc/fix-rust-udf-build branch from f180232 to 602a6b3 Compare October 11, 2024 07:23
@stdrc stdrc enabled auto-merge October 11, 2024 07:23
stdrc added 3 commits October 11, 2024 16:32
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
@stdrc stdrc force-pushed the rc/fix-rust-udf-build branch from 602a6b3 to aac567f Compare October 11, 2024 08:32
@stdrc stdrc added this pull request to the merge queue Oct 11, 2024
Merged via the queue into main with commit 360d552 Oct 11, 2024
30 of 31 checks passed
@stdrc stdrc deleted the rc/fix-rust-udf-build branch October 11, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: cannot build Rust UDF
2 participants