fix(metric): correctly update storage object metric #18835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Li0k
approved these changes
Oct 10, 2024
| next_start_key: Option<String>, | ||
| value: u64, | ||
| ) { | ||
| // Encounter an update without pagination, replace current state. |
There was a problem hiding this comment.
add doc for "manualy trigger full gc" ?
zwang28
commented
Oct 15, 2024
| optional string next_start_after = 4; | ||
| // Start key of this page. | ||
| optional string start_after = 5; |
There was a problem hiding this comment.
Another PB change related to severless compaction @yufansong @arkbriar
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
After the LIST pagination refactor #18737, the meaning of
ReportFullScanTaskRequest::total_object_counthas changed from "total object count in the object store" to "total object count of current page in the object store".To correctly set the metric
total_object_countfor prometheus,ReportFullScanTaskRequest::total_object_countshould be accumulated on a per-page basis, and then updated in prometheus at the end.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.