Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): bump protoc version #18824

Merged
merged 3 commits into from
Oct 9, 2024
Merged

fix(ci): bump protoc version #18824

merged 3 commits into from
Oct 9, 2024

Conversation

kwannoel
Copy link
Contributor

@kwannoel kwannoel commented Oct 9, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Currently it's failing in ci. Could be because we are using an ancient protoc version 3. I just bump to an arbitrary new one, which is used on my system.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@github-actions github-actions bot added the type/fix Bug fix label Oct 9, 2024
@kwannoel kwannoel requested a review from BugenZhao October 9, 2024 08:42
This reverts commit d483c06.
@kwannoel
Copy link
Contributor Author

kwannoel commented Oct 9, 2024

Dashboard workflow from test commit passes.

@kwannoel kwannoel enabled auto-merge October 9, 2024 08:49
@kwannoel kwannoel requested a review from xxchan October 9, 2024 08:50
Copy link
Member

@BugenZhao BugenZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be because we are using an ancient protoc version 3.

I think it's due to a change on the versioning, like

protocolbuffers/protobuf#10704 (comment)

@@ -17,7 +17,7 @@ jobs:
node-version: 18
- uses: arduino/setup-protoc@v3
with:
version: "3.x"
version: "25.x"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we use the latest release 28?

@kwannoel kwannoel added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit b8c3fcb Oct 9, 2024
9 of 10 checks passed
@kwannoel kwannoel deleted the kwannoel/protoc branch October 9, 2024 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants