-
Notifications
You must be signed in to change notification settings - Fork 595
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(expr): cast untyped start
and step
when inferring type for generate_series
#18786
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
start
and step
when inferring type for generate_series
start
and step
when inferring type for generate_series
start
and step
when inferring type for generate_series
start
and step
when inferring type for generate_series
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Can you add a batch plan test as well? |
In batch, we won't throw error until the query is executed by backend. So we can't test it in planner test.🤪 |
An slt test would be good then, to make sure the type checking behaviour is consistent between batch and streaming. Won't block this PR on it. |
newly-added e2e test failed because of a weird bug: #18790 |
01ff380
to
991ab71
Compare
Merge commits are not allowed on this repository
213e88a
to
851adc9
Compare
991ab71
to
420e45c
Compare
`generate_series`
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
420e45c
to
ee3ff68
Compare
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Fix #18729.
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.