Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(expr): cast untyped start and step when inferring type for generate_series #18786

Merged
merged 3 commits into from
Oct 9, 2024

Conversation

stdrc
Copy link
Member

@stdrc stdrc commented Oct 2, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Fix #18729.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member Author

stdrc commented Oct 2, 2024

@stdrc stdrc changed the title cast untyped start and step when inferring type for generate_series fix(cast untyped start and step when inferring type for generate_series Oct 2, 2024
@stdrc stdrc changed the title fix(cast untyped start and step when inferring type for generate_series fix(expr): cast untyped start and step when inferring type for generate_series Oct 2, 2024
@github-actions github-actions bot added type/fix Bug fix and removed Invalid PR Title labels Oct 2, 2024
@stdrc stdrc marked this pull request as ready for review October 2, 2024 10:05
@stdrc stdrc requested review from xiangjinwu and kwannoel October 2, 2024 10:05
Copy link
Contributor

@kwannoel kwannoel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kwannoel
Copy link
Contributor

kwannoel commented Oct 2, 2024

Can you add a batch plan test as well?

@stdrc
Copy link
Member Author

stdrc commented Oct 2, 2024

Can you add a batch plan test as well?

In batch, we won't throw error until the query is executed by backend. So we can't test it in planner test.🤪

@kwannoel
Copy link
Contributor

kwannoel commented Oct 2, 2024

Can you add a batch plan test as well?

In batch, we won't throw error until the query is executed by backend. So we can't test it in planner test.🤪

An slt test would be good then, to make sure the type checking behaviour is consistent between batch and streaming.

Won't block this PR on it.

@stdrc stdrc enabled auto-merge October 3, 2024 08:03
@stdrc
Copy link
Member Author

stdrc commented Oct 3, 2024

newly-added e2e test failed because of a weird bug: #18790

@stdrc stdrc force-pushed the rc/fix-streaming-gen-series-now-type-inferrence branch from 01ff380 to 991ab71 Compare October 8, 2024 10:23
@stdrc stdrc changed the base branch from main to rc/fix-distributed-batch-query-error-reporting October 8, 2024 10:23
auto-merge was automatically disabled October 8, 2024 10:23

Merge commits are not allowed on this repository

@stdrc stdrc force-pushed the rc/fix-distributed-batch-query-error-reporting branch from 213e88a to 851adc9 Compare October 8, 2024 19:33
@stdrc stdrc force-pushed the rc/fix-streaming-gen-series-now-type-inferrence branch from 991ab71 to 420e45c Compare October 8, 2024 19:33
Base automatically changed from rc/fix-distributed-batch-query-error-reporting to main October 8, 2024 20:06
stdrc added 3 commits October 9, 2024 13:00
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
@stdrc stdrc force-pushed the rc/fix-streaming-gen-series-now-type-inferrence branch from 420e45c to ee3ff68 Compare October 9, 2024 05:01
@stdrc stdrc enabled auto-merge October 9, 2024 05:07
@stdrc stdrc added this pull request to the merge queue Oct 9, 2024
Merged via the queue into main with commit 81780be Oct 9, 2024
30 of 31 checks passed
@stdrc stdrc deleted the rc/fix-streaming-gen-series-now-type-inferrence branch October 9, 2024 06:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/fix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Streaming generate_series should work with unknown as start
3 participants