refactor: additional column logic #18633
Conversation
Signed-off-by: tabVersion <[email protected]>
Signed-off-by: tabVersion <[email protected]>
| COMPATIBLE_ADDITIONAL_COLUMNS | ||
| .get(connector_name) | ||
| .and_then(|map| map.get(format)) |
There was a problem hiding this comment.
I think add format to the hashmap makes it harder to manage.
| COMPATIBLE_ADDITIONAL_COLUMNS | |
| .get(connector_name) | |
| .and_then(|map| map.get(format)) | |
| let compactible_additional_columns = COMPATIBLE_ADDITIONAL_COLUMNS | |
| .get(connector_name)?; | |
| match format { // check format ... } |
may be better
There was a problem hiding this comment.
Because "connector metadata" and "format metadata" are relatively orthogonal.
There was a problem hiding this comment.
make sense.
But I am not sure whether we allow including key for debezium format. This is the only concern I use the nested structure.
| if !additional_column_names.is_empty() { | ||
| return Err(RwError::from(ProtocolError(format!( | ||
| "FORMAT DEBEZIUM forbids additional columns, but got {:?}", | ||
| additional_column_names | ||
| )))); | ||
| } |
There was a problem hiding this comment.
There are other branches not covered: "(debezium, avro)", "(maxwell, json)", "(canal, json)", etc.
Signed-off-by: tabVersion <[email protected]>
|
This PR has been open for 60 days with no activity. If it's blocked by code review, feel free to ping a reviewer or ask someone else to review it. If you think it is still relevant today, and have time to work on it in the near future, you can comment to update the status, or just manually remove the You can also confidently close this PR to keep our backlog clean. (If no further action taken, the PR will be automatically closed after 7 days. Sorry! 🙏) |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
making additional column logic
formataware.We can support more columns from
formatlevel, eg. event time from debezium metadata. And more explicit def of which column is allowed.related #18357
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.