-
Notifications
You must be signed in to change notification settings - Fork 592
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(agg): fix embedded UDAF as window function #18632
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ce07651
to
65550e6
Compare
65550e6
to
cc81eaf
Compare
690a9b0
to
118d464
Compare
@kwannoel Can you plz help take a look at the backward comp test? https://buildkite.com/risingwavelabs/pull-request/builds/58667#019222d7-dbaf-4bb7-bdd4-78927355e79a It seems relate to the openssl linking issue, but what's strange is that I've rebased onto main 1 hour ago, which should contain your fix. |
Oh I see.. v1.10.2 just got release. And it uses dynamic linking too. Let me fix it. |
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
…pScalar` Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
Signed-off-by: Richard Chien <[email protected]>
118d464
to
48c149c
Compare
Removing the |
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Fixes #18436.
As a quick fix, currently the
retract
method of embedded UDAF, if defined, is not utilized. Let's fix the functionality first, and optimize the performance in later PR, which requires some more work to do.Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.