Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cherrypick feat(sink): support sink map to protobuf (#18552) to branch release-2.0 #18616

Merged
merged 3 commits into from
Sep 23, 2024

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Sep 20, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

close #18615

also cherry-pick #18563 for convenience

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xxchan xxchan requested review from lmatz and chenzl25 September 20, 2024 06:22
@xxchan xxchan enabled auto-merge September 20, 2024 06:23
@xxchan xxchan changed the title feat: improve error of building key encoder (#18563) cherrypick feat(sink): support sink map to protobuf (#18552) to branch release-2.0 Sep 20, 2024
@xxchan
Copy link
Member Author

xxchan commented Sep 20, 2024

depends on #18558

Copy link
Member

@stdrc stdrc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rubber stamp

@xxchan xxchan added this pull request to the merge queue Sep 23, 2024
Merged via the queue into release-2.0 with commit da6dd46 Sep 23, 2024
26 of 27 checks passed
@xxchan xxchan deleted the xxchan/c3 branch September 23, 2024 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants