Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(compaction): introduce new task status for serverless compaction #18575

Merged
merged 1 commit into from
Sep 18, 2024
Merged

feat(compaction): introduce new task status for serverless compaction #18575

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions proto/hummock.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -358,6 +358,10 @@ message CompactTask {
TRACK_SST_OBJECT_ID_FAILED = 12;
NO_AVAIL_CPU_RESOURCE_CANCELED = 13;
HEARTBEAT_PROGRESS_CANCELED = 14;

// for serverless compaction
SERVERLESS_SEND_FAIL_CANCELED = 15;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will serverless compaction controller add more error codes in the future? I am thinking whether we should have one error code only for all serverless compaction controller error.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will serverless compaction controller add more error codes in the future?

I think it's possible, but not in a near future since the serverless protocol won't change frequently.

I am thinking whether we should have one error code only for all serverless compaction controller error.

I'm fine if the error message isn't lost. But seems we rely on the error code to tell the error kind, I think we'd better add more when necessary.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it depends on whether we introduce more state to the compact task, e.g. table_catalog. As we iterate through the logic of the compact task, we may introduce more corresponding error

SERVERLESS_TABLE_NOT_FOUND_CANCELED = 16;
}
// SSTs to be compacted, which will be removed from LSM after compaction
repeated InputLevel input_ssts = 1;
Expand Down
Loading