feat(cdc): support default column in auto schema mapping #18571
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StrikeW
changed the title
BugenZhao
reviewed
Sep 20, 2024
src/connector/src/error.rs
Outdated
| @@ -42,6 +42,7 @@ def_anyhow_newtype! { | |||
| url::ParseError => "failed to parse url", | |||
| serde_json::Error => "failed to parse json", | |||
| csv::Error => "failed to parse csv", | |||
| rust_decimal::Error => transparent, | |||
There was a problem hiding this comment.
I think some context must be attached when converting a rust_decimal::Error to ConnectorError. If it's the case, could you remove the line here and explicitly call .context() on the result?
Comment on lines
123
to
125
| _ => { | ||
| unreachable!("unexpected default value type for integer column") | ||
| } |
There was a problem hiding this comment.
Since the default and data_type are from external systems, shall we return an error instead of panicking here?
| unreachable!("unexpected default value type for float column") | ||
| } | ||
| }, | ||
| ColumnDefault::String(val) | ColumnDefault::CustomExpr(val) => { |
There was a problem hiding this comment.
Why do we involve CustomExpr here?
There was a problem hiding this comment.
refactored. CustomExpr cannot be supported right now.
hzxa21
reviewed
Sep 23, 2024
StrikeW
added a commit
that referenced
this pull request
Sep 26, 2024
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
support default column in auto schema mapping for mysql and postgres.
The implementation only support constant expression, if the default value cannot be parsed it will be ignored.
close #18359
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.