Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(subscription): notify frontend on changelog epoch changes via notification #18538

Closed
wants to merge 5 commits into from

Conversation

xxhZs
Copy link
Contributor

@xxhZs xxhZs commented Sep 14, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Previously we needed to call rpc once to get the subscription's epoch list each time.
To implement a block cursor, we store a copy in the frontend and use notify frontend to update it.

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

@xxhZs xxhZs force-pushed the xxh/support-block-cursor branch from 4b01cf7 to 971207d Compare September 14, 2024 08:45
@xxhZs xxhZs changed the title refactor(subscription0): Mv changlog epochs from meta to frontend refactor(subscription0): Mv lsit_changlog_epochs from meta to frontend Sep 14, 2024
@graphite-app graphite-app bot requested a review from a team September 14, 2024 09:05
@hzxa21 hzxa21 changed the title refactor(subscription0): Mv lsit_changlog_epochs from meta to frontend refactor(subscription): notify frontend on changelog epoch changes via notification Sep 18, 2024
@xxhZs xxhZs requested a review from hzxa21 September 18, 2024 03:06
@wenym1
Copy link
Contributor

wenym1 commented Sep 18, 2024

#18570 provides similar functionalities.

@xxhZs xxhZs closed this Sep 18, 2024
@xxhZs xxhZs deleted the xxh/support-block-cursor branch September 24, 2024 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants