Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(source): support ingesting protobuf map #18512

Merged
merged 5 commits into from
Sep 13, 2024

Conversation

xxchan
Copy link
Member

@xxchan xxchan commented Sep 12, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

fix #13387

#17743

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Member Author

xxchan commented Sep 12, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @xxchan and the rest of your teammates on Graphite Graphite

@xxchan xxchan marked this pull request as ready for review September 12, 2024 09:21
Copy link
Contributor

@chenzl25 chenzl25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xxchan xxchan force-pushed the xxchan/constitutional-gerbil branch from cb1d07c to 9f2cfd1 Compare September 13, 2024 06:48
@xxchan xxchan requested a review from a team as a code owner September 13, 2024 06:48
@xxchan xxchan requested review from xiangjinwu and removed request for a team September 13, 2024 06:48
@xxchan xxchan force-pushed the 09-12-feat_source_support_ingesting_protobuf_map branch from 5860141 to 2eedda1 Compare September 13, 2024 06:49
Base automatically changed from xxchan/constitutional-gerbil to main September 13, 2024 08:45
@graphite-app graphite-app bot requested a review from a team September 13, 2024 08:45
@xxchan xxchan force-pushed the 09-12-feat_source_support_ingesting_protobuf_map branch from 3dcd917 to 8cc9a55 Compare September 13, 2024 09:16
@xxchan xxchan added this pull request to the merge queue Sep 13, 2024
Merged via the queue into main with commit 8eed769 Sep 13, 2024
30 of 31 checks passed
@xxchan xxchan deleted the 09-12-feat_source_support_ingesting_protobuf_map branch September 13, 2024 10:23
xxchan added a commit that referenced this pull request Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

connector: support protobuf map type in source
3 participants