-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(source): support ingesting protobuf map #18512
Merged
xxchan
merged 5 commits into
main
from
09-12-feat_source_support_ingesting_protobuf_map
Sep 13, 2024
Merged
feat(source): support ingesting protobuf map #18512
xxchan
merged 5 commits into
main
from
09-12-feat_source_support_ingesting_protobuf_map
Sep 13, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
9 tasks
chenzl25
approved these changes
Sep 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
xiangjinwu
reviewed
Sep 13, 2024
xxchan
force-pushed
the
xxchan/constitutional-gerbil
branch
from
September 13, 2024 06:48
cb1d07c
to
9f2cfd1
Compare
xxchan
force-pushed
the
09-12-feat_source_support_ingesting_protobuf_map
branch
from
September 13, 2024 06:49
5860141
to
2eedda1
Compare
xiangjinwu
approved these changes
Sep 13, 2024
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
Signed-off-by: xxchan <[email protected]>
xxchan
force-pushed
the
09-12-feat_source_support_ingesting_protobuf_map
branch
from
September 13, 2024 09:16
3dcd917
to
8cc9a55
Compare
xxchan
added a commit
that referenced
this pull request
Sep 17, 2024
Signed-off-by: xxchan <[email protected]>
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
fix #13387
#17743
Checklist
./risedev check
(or alias,./risedev c
)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.