feat(iceberg): support eq delete merge on read for iceberg #18448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Li0k
reviewed
Sep 10, 2024
chenzl25
reviewed
Sep 10, 2024
hzxa21
reviewed
Sep 10, 2024
Cargo.toml
Outdated
Comment on lines
145
to
147
| iceberg = { git = "https://github.com/risingwavelabs/iceberg-rust.git", rev = "682b38037dafa78ebbc6e0479844e980c5ed68a4" } | ||
| iceberg-catalog-rest = { git = "https://github.com/risingwavelabs/iceberg-rust.git", rev = "682b38037dafa78ebbc6e0479844e980c5ed68a4" } | ||
| iceberg-catalog-glue = { git = "https://github.com/risingwavelabs/iceberg-rust.git", rev = "682b38037dafa78ebbc6e0479844e980c5ed68a4" } |
There was a problem hiding this comment.
Just curious, do we have a plan to contribute back to upstream to expose delete files?
src/expr/impl/Cargo.toml
Outdated
| @@ -51,7 +51,7 @@ itertools = { workspace = true } | |||
| jsonbb = { workspace = true } | |||
| linkme = { version = "0.3", features = ["used_linker"] } | |||
| md5 = "0.7" | |||
| moka = { version = "0.12", features = ["sync"] } | |||
| moka = { version = "0.12.8", features = ["sync"] } | |||
There was a problem hiding this comment.
Any specific reason that we want to pin to a specific version here?
There was a problem hiding this comment.
Since we update the version of iceberg_rust in this pr, and it depends on moka ^0.12.8
chenzl25
reviewed
Sep 11, 2024
chenzl25
reviewed
Sep 12, 2024
xxhZs
force-pushed
the
xxh/iceberg_merge_on_read
branch
from
0fc921e to
2004482
Compare
xxhZs
force-pushed
the
xxh/iceberg_merge_on_read
branch
from
2004482 to
e39af11
Compare
xxhZs
force-pushed
the
xxh/iceberg_merge_on_read
branch
from
b516b85 to
e0df8cc
Compare
chenzl25
approved these changes
Sep 12, 2024
xxhZs
force-pushed
the
xxh/iceberg_merge_on_read
branch
from
741b069 to
83c30a6
Compare
Li0k
approved these changes
Sep 13, 2024
| let visibilitys: Vec<_> = chunk | ||
| .columns() | ||
| .iter() | ||
| .zip_eq(column_names.clone()) |
| } | ||
| Ok(splits | ||
| .into_iter() | ||
| .filter(|split| !split.files.is_empty()) | ||
| .collect_vec()) | ||
| } | ||
|
|
||
| async fn get_require_field_names( |
There was a problem hiding this comment.
Please add some doc / example for this case
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
support merge on read for iceberg source.
Only support eq delete
The delete file's pk must be consistent
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.