feat(nimtable): nimtable make drop table more robust #18422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chenzl25
requested review from
Li0k and
xxhZs
and removed request for
stdrc and
a team
hzxa21
reviewed
Sep 5, 2024
Comment on lines
1315
to
1319
| let s3_region = if let Ok(region) = std::env::var("AWS_REGION") { | ||
| region | ||
| } else { | ||
| "us-east-1".to_string() | ||
| }; |
There was a problem hiding this comment.
Should this be a required field without default value?
There was a problem hiding this comment.
You are right. Currently, the default value is used in local development. We can make all of them required.
| "us-east-1".to_string() | ||
| }; | ||
|
|
||
| let s3_endpoint = if let Ok(endpoint) = std::env::var("AWS_ENDPOINT_URL") { |
| endpoint | ||
| } else { | ||
| "http://127.0.0.1:9301".to_string() | ||
| }; | ||
|
|
||
| let s3_region = if let Ok(region) = std::env::var("AWS_REGION") { | ||
| region | ||
| let s3_bucket = if let Ok(bucket) = std::env::var("AWS_BUCKET") { |
chenzl25
added a commit
that referenced
this pull request
Sep 20, 2024
chenzl25
added a commit
that referenced
this pull request
Sep 20, 2024
chenzl25
added a commit
that referenced
this pull request
Sep 20, 2024
chenzl25
added a commit
that referenced
this pull request
Sep 20, 2024
chenzl25
added a commit
that referenced
this pull request
Sep 20, 2024
chenzl25
added a commit
that referenced
this pull request
Sep 25, 2024
chenzl25
added a commit
that referenced
this pull request
Sep 26, 2024
Li0k
pushed a commit
that referenced
this pull request
Oct 14, 2024
Li0k
pushed a commit
that referenced
this pull request
Oct 25, 2024
chenzl25
added a commit
that referenced
this pull request
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.