feat: variable vnode count support in vnode structure #18381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @BugenZhao and the rest of your teammates on |
4 tasks
fuyufjh
approved these changes
Sep 4, 2024
Comment on lines
+55
to
+58
| pub const COUNT: usize = 1 << 8; | ||
| /// The maximum value of the virtual node. | ||
| // TODO(var-vnode): remove this and only keep `MAX_FOR_TEST` | ||
| pub const MAX: VirtualNode = VirtualNode::from_index(Self::COUNT - 1); |
There was a problem hiding this comment.
I think COUNT and MAX mean the same thing. Shall we merge them into one? Or do you plan to do it in the future PRs?
There was a problem hiding this comment.
Yes. They are just in different types. Will refactor in future PRs.
4 tasks
BugenZhao
force-pushed
the
bz/var-vnode-vnode-struct
branch
from
574ee3f to
9c99bd7
Compare
BugenZhao
force-pushed
the
bz/var-vnode-vnode-struct
branch
from
9c99bd7 to
e1ad5ea
Compare
4 tasks
Signed-off-by: Bugen Zhao <[email protected]>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.
What's changed and what's your intention?
This is a progress towards #15900.
This PR refactors the
VirtualNodeandVnodeMapping. Logic changes are:VirtualNode::COUNT.Checklist
./risedev check(or alias,./risedev c)Documentation
Release note
If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.